Conversation
As far as I can tell, this has never been used. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
It was never updated in a meaningful way. It was only used directly in lsb_release, which is a dead standard. It was included in the os-release `PRETTY_NAME` but not as a field on its own. Closes: #88 Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
This leverages the branding eclass that was recently added to Gentoo. Since originally preparing this commit, these fields were added to our make.conf, but setting them in the profile is more versatile, allowing for downstreams. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
These have probably have been broken for years. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
krnowak
approved these changes
Feb 27, 2026
Comment on lines
+46
to
+53
| NAME="$BRANDING_OS_NAME" | ||
| ID="$BRANDING_OS_ID" | ||
| ID_LIKE="$BRANDING_OS_ID_LIKE" | ||
| VERSION="$FLATCAR_VERSION" | ||
| VERSION_ID="$FLATCAR_VERSION_ID" | ||
| BUILD_ID="$FLATCAR_BUILD_ID" | ||
| SYSEXT_LEVEL="1.0" | ||
| PRETTY_NAME="$BRANDING_OS_PRETTY_NAME" |
Member
There was a problem hiding this comment.
I was wondering if we could do NAME=${BRANDING_OS_NAME@Q} instead. That would make sure that quoting is done correctly. On the other hand, that probably would break some things because I'm sure that there is some script out there parsing the file and assuming that there are either no quotes or only double quotes. ${BRANDING_OS_NAME@Q} would result in using single quotes, I think.
Anyway, doesn't matter, it's not like we are going to put strange characters here anyway.
| [ -d "$ROOT_FS_DIR" ] || die "Root FS does not exist? ($ROOT_FS_DIR)" | ||
|
|
||
| OS_NAME="Flatcar Container Linux by Kinvolk" | ||
| OS_CODENAME="Oklo" |
Member
There was a problem hiding this comment.
This must stay. It's not negotiable. Oklo Inc. promised me a nuclear reactor if we keep it.
;)
| BRANDING_OS_ID="flatcar" | ||
| BRANDING_OS_ID_LIKE="coreos" | ||
| BRANDING_OS_HOME_URL="https://flatcar.org" | ||
| BRANDING_OS_SUPPORT_URL="https://groups.google.com/forum/#!forum/flatcar-linux-user" |
Member
There was a problem hiding this comment.
I suppose SUPPORT_URL is not used, yes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the "Oklo" and use Gentoo's branding.eclass
The release codename was never updated in a meaningful way. It was only used directly in lsb_release, which is a dead standard. It was included in the os-release
PRETTY_NAMEbut not as a field on its own.Setting the os-release fields in the profile allows them to be used by the new branding.eclass, which is now applied to various packages, particularly GNU ones.
Since originally preparing the commit, these fields were added to our make.conf, but setting them in the profile is more versatile, allowing for downstreams.
This also drops some dead files.
How to use
Testing done
I tested this a while ago, but I'll give it a fresh look.
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.